search

tmort / Socialite

Other
1.68k stars 163 forks source link

Sharing buttons not appearing in older IEs #5

Closed ashrobbins closed 12 years ago

ashrobbins commented 12 years ago

http://www.ashrobbins.com/playground/socialite-testing.html

At the above URL I made a quick test page to try and replicate an issue I've been having on a build I'm working on at work (sorry can't share that particular page). The code used in the above page is the same as that which I'm having trouble with though.

Basically it works perfectly in Chrome, Firefox, Opera, Safari and IE9, but in IEs 8 and 7 I get really inconsistent results. Sometimes all three buttons appear, sometimes only one, sometimes only two. What I can say is that the Tweet button is the one that DOES always appear.

Sorry dude, I know you asked me to be specific! Don't know whether you can spot anything obvious I'm doing wrong in the code.

tomalterman commented 12 years ago

Issue appears on the http://socialitejs.com example site in IE7. Neither facebook or google plus seem to appear in that browser.

dbushell commented 12 years ago

Thanks, I'll look into this now that I have access to a IE7/8 machine!

dbushell commented 12 years ago

I'm only seeing issues with Facebook in IE8, it may be because the iframe has no width/height. Though in IE7 Facebook is working fine but Google+ is not... bear with me!

my hover/scroll demos don't work at all in IE7/8 but I'm assuming poor use of jQuery there since no Socialite activation actually gets triggered.

tomalterman commented 12 years ago

Looking at the Google+ API it seems to not support IE7 at all so I dont think its anything to do with you, though might be nice to include an IE7 fallback.

We've implemented a bit of code to remove the socialite class if in IE7 so it doesn't run and simply shows the static link with a G+ image.

On 29 December 2011 18:12, David Bushell < reply@reply.github.com

wrote:

I'm only seeing issues with Facebook in IE8, it may be because the iframe has no width/height. Though in IE7 Facebook is working fine but Google+ is not... bear with me!

my hover/scroll demos don't work at all in IE7/8 but I'm assuming poor use of jQuery there since no Socialite activation actually gets triggered.

Reply to this email directly or view it on GitHub: https://github.com/dbushell/Socialite/issues/5#issuecomment-3303309

aearly commented 12 years ago

I will also echo this issue -- FB like buttons are consistently not appearing in IE 7 and 8 for me, even on http://socialitejs.com/ . Falling back to the sharing API as a workaround for now in my project....

ibrent commented 12 years ago

I don't see this happening in IE7/8 anymore. Was this fixed? Thx!

dbushell commented 12 years ago

@ibrent yes, from what I've tested Socialite v2 fixes Facebook issues in IE7/8.

A few of the buttons don't like IE7 (Google+) but that is their fault (I believe!)