Pass globals with IIFE, add minified version & fix demos in IE versions less than 9 - Githubissues

tmort / Socialite

Other

1.68k stars 163 forks source link

Pass globals with IIFE, add minified version & fix demos in IE versions less than 9 #9

Closed kristerkari closed 12 years ago

kristerkari commented 12 years ago

Here's what I've done:

Passed in used globals with IIFEs to reduce scope lookups (and for better minification)
Cached some prop lookups to help minification
Added a minified version
Fixed demos in IE < 9 by adding html5shiv
UglifyJS with current version:

Ugly version: Old version: 11813 bytes New version: 5398 bytes Saved: 6415 (result is 45.6% of original)

UglifyJS with new (my) version:

Ugly version: Old version: 12050 bytes New version: 5197 bytes Saved: 6853 (result is 43.1% of original)

dbushell commented 12 years ago

This looks good, I'll give it a test and then merge later today. Thanks Krister.