search

tmp64 / BugfixedHL-Rebased

Bugfixed and improved Half-Life
GNU General Public License v3.0
108 stars 22 forks source link

Client: Allow to specify name for kill sound and regulate volume #133

Closed SmileyAG closed 8 months ago

SmileyAG commented 2 years ago

Closes #132

tmp64 commented 2 years ago

Volume control will stop working as soon as "Apply" is pressed in the advanced options dialog because CCvarCheckButton only allows boolean values https://github.com/tmp64/BugfixedHL-Rebased/blob/07aecfff8bacaccc1aad1516d342041e4a4aca87/src/game/client/gameui/options/cvar_check_button.cpp#L17-L40

I see two ways to resolve that a. Replace checkboxes with sliders. But there's barely any space for anything as it is. b. Modify CCvarCheckButton to only update the value if it was changed.

tmp64 commented 8 months ago

Rebased on top of master

tmp64 commented 8 months ago

Thanks!

tmp64 commented 8 months ago

I see two ways to resolve that a. Replace checkboxes with sliders. But there's barely any space for anything as it is. b. Modify CCvarCheckButton to only update the value if it was changed.

I changed CCvarCheckButton to only apply if the user clicked the checkbox (f4deeab9168dff03444683d6ef59cd0be15f4ab6).