tmpim / shitty.dl

Heavyweight featurecreep file hosting server in node.js
8 stars 3 forks source link

Edit files with monaco editor. #24

Closed Wojbie closed 5 years ago

Wojbie commented 6 years ago

This adds ability for logged in user to edit contents of files stored in shitty using monaco editor and using its nice code highlighers, key shortcuts and other fancy stuff. Sadly due to limitations of monaco editor this is only possible from desktop not from mobile devices.

Sidenote - in future when/if monaco supports the mobile devices this could be also used as current /paste replacement. For now opening editor when not logged it shows editor in read-only mode to showcase that.

Lemmmy commented 6 years ago

!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1!!!!!1

Wojbie commented 6 years ago

Eloquent as ever i see.

Lemmmy commented 5 years ago

It's working great, really splendid work! I've made a few minor formatting changes to the code, as well as some changes to the spacing in the popup:

If you're happy with the changes, then I'm happy to merge.

Wojbie commented 5 years ago

Awesome you got that buttons to line up. And yea it all looks good for me.