search

tmpkus / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

Invisible PClips are reported to be picked by InputEventHandler #234

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I noted in Issue 113, we added a guard in PNode.fullPick() to only proceed if 
the node is visible. PClip duplicates PNode.fullPick() to support the clipping 
behavior.

The easy workaround is to override PClip and reintroduce the guard, but I 
wanted to get this out as an minor issue, b/c it the changed behavior threw me 
when I converted a PNode to a PClip.

Should we make PClip behave like PNode in this regard? Should we introduce a 
protected method in PNode so that PClip doesn't have to override the entire 
PNode's fullPaint() method just to change one line? I recommend we do something 
like this in next major version of Piccolo (don't want to change PClip's 
behavior for a minor version).

Original issue reported on code.google.com by atdi...@gmail.com on 28 Dec 2011 at 9:29

GoogleCodeExporter commented 9 years ago 
Let me clarify, as my first paragraph above was unclear... 

PClip.fullPick() doesn't have the getVisible() check that PNode.fullPick() has, 
so PClip nodes are picked even if they are invisible.

Original comment by atdi...@gmail.com on 28 Dec 2011 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 31 Aug 2012 at 8:24

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 26 Nov 2013 at 9:11