search

tmpkus / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

PStyledText too closed for extension in derivations #261

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I needed support for dotted underlines in a PStyledText but wasn't able to add 
appropriate functionality. In fact it would have been quite easy to add the 
functionality in a derived class if PStyledText were a bit more open for 
overrides in derivations.

Please consider the attached patch as an improvement. It does not change the 
existing functionality but just opens it a bit by
- Making some methods protected instead of private
- Separating some code blocks in protected template methods
- Adding getters to inner classes
- Encapsulating the construction of SegmentInfo in a method to allow derived 
classes providing an extended type instead

Original issue reported on code.google.com by jless...@gmx.de on 29 Dec 2014 at 7:37

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 29 Dec 2014 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 29 Dec 2014 at 11:39

GoogleCodeExporter commented 9 years ago 
Patch applied in revision 1273, thanks!

Please review and if looks ok, mark as Status: Verified

Original comment by heue...@gmail.com on 30 Dec 2014 at 3:46