tmspzz / Rome

Carthage cache for S3, Minio, Ceph, Google Storage, Artifactory and many others
MIT License
820 stars 57 forks source link

Rome not failing when engine exit code is not zero #236

Open acecilia opened 3 years ago

acecilia commented 3 years ago

Rome version: 0.23.3.64 OS: catalina 10.15.7

Hi 👋

Problem

Rome is not failing when the engine exists with a code different than zero.

Expectation

When the engine returns an exit code different than zero, Rome should also fail and exit with a code different than zero. For example, using the default google engine from this repository:

        print(f"{remote_path} 404'ed")
        zip_file_path.unlink()
        exit(1)

If such code path gets executed, Rome should fail instead of continuing execution

tmspzz commented 3 years ago

Thanks for reporting. I'll take a look