search

tmszdmsk / arij

another really interesting Jira client for Android
8 stars 5 forks source link

Longer list and deep linking #23

Closed marcellourbani closed 9 years ago

marcellourbani commented 9 years ago

Tomasz, I have three changes here: 1) deep linking 2) smaller font in issue list, show last 4 char 3) dummy changes to get it to build in my version of android studio. I think the first might interest you, it's a bit unpolished (see below) but works, the rest is your call. Notes on the deep link: -first version removed the account list from history, but then it was VERY tricky to change account or even go to an issue list. -couldn't find a way to make it react to specific URLs it didn't know in advance. So it will be proposed for any URL who matches https:browse/ -if you enter with an url for which you don't have an account it tells you in a dialog, but doesn't show the add account activity with the missing prefix

ikogan commented 9 years ago

I love the deep linking idea, but the broadness of the intent filter concerns me. Is there a way we can make it something like https?://.*/browse/[a-zA-Z0-9]+-[0-9]+ or something similar? Effectively whatever Jira's regex is for issue IDs.

marcellourbani commented 9 years ago

Didn't try that for 2 reasons : 1) not sure what is the actual jira regex 2) looks like it is a simple glob, only does *, no square brackets

Marcello On 24 Mar 2015 23:36, "Ilya Kogan" notifications@github.com wrote:

I love the deep linking idea, but the broadness of the intent filter concerns me. Is there a way we can make it something like https?://.*/browse/[a-zA-Z0-9]+-[0-9]+ or something similar? Effectively whatever Jira's regex is for issue IDs.

— Reply to this email directly or view it on GitHub https://github.com/tmszdmsk/arij/pull/23#issuecomment-85740482.

marcellourbani commented 9 years ago

I hate having it broad, but can't find better other than compiling with my prefix in full. Don't think is a disaster though : the user is more likely to pick chrome than us for random links. On 24 Mar 2015 23:46, "Marcello Urbani" marcello.urbani@gmail.com wrote:

Didn't try that for 2 reasons : 1) not sure what is the actual jira regex 2) looks like it is a simple glob, only does *, no square brackets

Marcello On 24 Mar 2015 23:36, "Ilya Kogan" notifications@github.com wrote:

I love the deep linking idea, but the broadness of the intent filter concerns me. Is there a way we can make it something like https?://.*/browse/[a-zA-Z0-9]+-[0-9]+ or something similar? Effectively whatever Jira's regex is for issue IDs.

— Reply to this email directly or view it on GitHub https://github.com/tmszdmsk/arij/pull/23#issuecomment-85740482.

ikogan commented 9 years ago

You're correct, it looks like globbing is all you've got. What if you did something like /browse/-?

marcellourbani commented 9 years ago

/browse is there. Will try .-. On 25 Mar 2015 00:28, "Ilya Kogan" notifications@github.com wrote:

You're correct, it looks like globbing is all you've got. What if you did something like /browser/-?

— Reply to this email directly or view it on GitHub https://github.com/tmszdmsk/arij/pull/23#issuecomment-85756040.

marcellourbani commented 9 years ago

/browse/.-. works, updated in the repository. Not sure whether I need a new pull request

On Wed, Mar 25, 2015 at 6:06 AM, Marcello Urbani marcello.urbani@gmail.com wrote:

/browse is there. Will try .-. On 25 Mar 2015 00:28, "Ilya Kogan" notifications@github.com wrote:

You're correct, it looks like globbing is all you've got. What if you did something like /browser/-?

— Reply to this email directly or view it on GitHub https://github.com/tmszdmsk/arij/pull/23#issuecomment-85756040.

tmszdmsk commented 9 years ago

Great improvement. I added some general comments. Will have a closer look in the evening (Warsaw time ;). Thanks.

tmszdmsk commented 9 years ago

Ok, I have few comments:

Please, write if you want to work more on those features.

marcellourbani commented 9 years ago

Point by point:

Last but not least: I do plan to work on this (at least to deliver the deeplink and truncation) but I'm doing it in my spare time, don't hold your breath :)

On Thu, Mar 26, 2015 at 5:38 AM, Tomasz Adamski notifications@github.com wrote:

Ok, I have few comments:

  • I think that it's a good practice to put different features in separate pull requests requests (In this case there should be three of them i think)
  • As i wrote in a comment, "truncation" should be defined in layout xml file
  • I researched deeplinking mechanism some time ago, and yes, from what I've found it's not possible to specify patterns dynamically.
  • I'm not sure that handling of those links should be done in AccountsList activity. I would put it in separate component that listens for those intents. I'm not "Android expert" but I guess it can be done in form of intentservice.
  • about the .iml files: I know i've put them there. They can be safely deleted.

Please, write if you want to work more on those features.

— Reply to this email directly or view it on GitHub https://github.com/tmszdmsk/arij/pull/23#issuecomment-86350213.