search

tmthrgd / go-bindata

A small utility which generates Go code from any file. Useful for embedding binary data in a Go program. [Obsolete].
https://golang.org/issue/35950
Other
72 stars 4 forks source link

Flunks go vet #4

Closed ryboe closed 7 years ago

ryboe commented 7 years ago 
$ go vet $(go list ./... | grep -v /vendor/)  # avoid scanning vendor/
header.go:71: +build comment must appear before package clause and be followed by a blank line
tmthrgd commented 7 years ago

This is actually a bug in go vet not in go-bindata. That build comment is inside a string literal (see header.go:71) and is part of the generated output.

While it is possible to silence this warning with a hack, I'd much rather not. I'll leave this open and marked wontfix, and I'll submit a bug report for go vet and see if that can be fixed.

tmthrgd commented 7 years ago

The go vet bug has already been reported in golang/go#12269 and golang/go#13533. The first was closed with the given reason "Not worth the trouble to fix." The second has also been closed with the given reason "probably not worth doing".

Unless you have a particularly pressing reason to address this, I think I'd rather leave it as wontfix.

tmthrgd commented 7 years ago

I reneged, and I fixed it in d825d59 with a small workaround.