Closed ryboe closed 7 years ago
Could you please run go get -u -t github.com/tmthrgd/go-bindata
and try again. They all seem to be missing dependency errors because go get does not fetch packages required for tests by default.
It passes! Sorry for the noise!
I do have one question, though. Will travis
automatically fetch the test deps too? If so, I can add staticcheck
to #6, and maybe some other code checkers too.
I thought it would. You can see in the travis log that it's running go get -t ...
. It wouldn't be much of a CI tool if it couldn't run the tests properly. 😅
Feel free to add staticcheck to #6 and other meaningful code checkers. Don't be afraid to push multiple commits to that pull request. I'd rather have them really granular than monolithic. So if you do add staticcheck or any others, do that in a new commit for each tool. I can rebase or mess around with it afterwards if I feel the need.
Don't worry about the noise, it's great to see you're interested. I pulled more late nighters than was remotely sensible working on this. 😂