Closed ryboe closed 7 years ago
I think I address all your feedback except for the trailing newline. I can't figure out how to stop my editor from adding that.
Good suggestions. I learned a few things.
That's been merged in cccbef9dd964f281bc88bc73523dc0eba52cda96. Thank you for your effort. 😄
I'm glad to hear that. I've picked up plenty of tricks over the years and some of them certainly are a tad obscure.
Flunk code that doesn't pass
gofmt -s
. Rungo vet
. Enable the race detector when running tests. ~Don't run tests in the vendor directory.~ Runstaticcheck
. Rungosimple
. Rununused
.