search

tmthrgd / go-bindata

A small utility which generates Go code from any file. Useful for embedding binary data in a Go program. [Obsolete].
https://golang.org/issue/35950
Other
72 stars 4 forks source link

Fix installation instructions #9

Closed davidkuridza closed 7 years ago

davidkuridza commented 7 years ago

Previous installation instruction yields following result:

$ go get -u -v github.com/tmthrgd/go-bindata
github.com/tmthrgd/go-bindata (download)
github.com/tmthrgd/go-bindata/internal/identifier
github.com/tmthrgd/go-bindata

$ which go-bindata
go-bindata not found

Adding ... fixes the problem since all dependencies are taken into account:

$ go get -u -v github.com/tmthrgd/go-bindata/...
github.com/tmthrgd/go-bindata (download)
github.com/tmthrgd/go-bindata/chain
github.com/tmthrgd/go-bindata/go-bindata
github.com/tmthrgd/go-bindata/restore
github.com/tmthrgd/go-bindata/vendor/github.com/golang/gddo/httputil/header
github.com/tmthrgd/go-bindata/httpasset

$ which go-bindata
/Users/david/go/bin/go-bindata

Tested with:

$ go version
go version go1.8.3 darwin/amd64
tmthrgd commented 7 years ago

I'm subtly hesitant because of the following (in README.md):

"The CLI also remains backwards compatible but is considered deprecated and will not be updated."

In that light I don't consider the installation instructions to be implicitly broken as they stand – and I definitely don't want to encourage the use of the go-bindata command line tool.

Nonetheless, this change looks perfectly acceptable to me and I'm happy to merge it. Thanks.

This is also related to #2.

davidkuridza commented 7 years ago

@tmthrgd thank you!