search

tmullender / ansible-maven-plugin

A Maven plugin to facilitate running Ansible adhoc commands and playbooks
MIT License
30 stars 10 forks source link

Making "ansible.syntaxCheck" property (ansible-playbook --syntax-check ) #10

Closed andrei-kalasok closed 8 years ago

tmullender commented 8 years ago

Hi Andrei

Thanks for the contribution. Before I merge it in could you add a test to show how this is used and check that it works? See src/it for the existing tests if you want an example.

andrei-kalasok commented 8 years ago

Hi Tim,

Could you pls check the last commits?

I've added 2 types of test:

and also description to README.md

tmullender commented 8 years ago

Hi Andrei

Commits merged. Let me know if you need this released soon if not I might try and make a few more updates.

Tim

andrei-kalasok commented 8 years ago

Hi Tim,

Great!

Well, it would be nice to have it soon, we'd like to include this check to out CI-process. But it can wait couple of weeks, it's a plan for our next sprint.

Best regards Andrei Kalasok

2016-08-13 10:24 GMT+02:00 Tim Mullender notifications@github.com:

Hi Andrei

Commits merged. Let me know if you need this released soon if not I might try and make a few more updates.

Tim

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tmullender/ansible-maven-plugin/pull/10#issuecomment-239609623, or mute the thread https://github.com/notifications/unsubscribe-auth/ADYEA2uD6S-p-tZM6Oe227b1a_DX1kd5ks5qfX8ugaJpZM4JdjVb .

tmullender commented 8 years ago

Released in 1.3.0

andrei-kalasok commented 8 years ago

Thanks a lot Tim!

Best regards Andrei Kalasok

2016-08-14 14:43 GMT+02:00 Tim Mullender notifications@github.com:

Released in 1.3.0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tmullender/ansible-maven-plugin/pull/10#issuecomment-239671703, or mute the thread https://github.com/notifications/unsubscribe-auth/ADYEA9XZj6Up5KhUlearyCm3IvSrumWJks5qfw1jgaJpZM4JdjVb .