search

tmullender / ansible-maven-plugin

A Maven plugin to facilitate running Ansible adhoc commands and playbooks
MIT License
30 stars 10 forks source link

promoteDebugAsInfo feature, fix #8 #9

Closed astik closed 9 years ago

tmullender commented 9 years ago

Hey Romain,

Thanks for the input, it's something I've thought about a couple of times but always just lived with the logDirectory option.

Implementation looks good, can you add a test though in src/it as an example and to show that it works?

astik commented 9 years ago

Unit tests have been pushed. I reused your 3 simple-ansible-* test in which I add the check for INFO log level. I didn't change your original test, I don't know if you wanted or not to check on the log level to assure that it was a DEBUG by default.

tmullender commented 9 years ago

I've removed the debug logging for those tests, which ensures that the line is being logged at a higher level and merged the changes into master

The snapshot is available in the sonatype repository, I'll aim to release it around the end of the month

astik commented 9 years ago

Hi, Any idea on when the plugin will be released as a stable version ? Thanks in advance

tmullender commented 9 years ago

Hey Romain,

1.2.0 was released at the end of March and contained this feature. Have you tried using it?

Tim

astik commented 9 years ago

Indeed, i missed the update. It works like a charm ! Still, there is no tag into Git for this version, am I missing something ? Anyway, thanks for this release, it will help me a lot to debug faulty processes =)