GNU Octave 4.4 compatibility.

siko1056 commented 6 years ago

This PR drops compatibility with GNU Octave versions smaller than 4.4.
No errors or warnings with gcc 7.3.
Test runs until https://github.com/tmullins/hdf5oct/blob/364310f0c01286a1cc744761696e549e560d01fb/test/h5test.m#L75 then errors with

Test h5create and h5write hyperslabs...
HDF5-DIAG: Error detected in HDF5 (1.10.1) thread 139933413857024:
  #000: H5D.c line 145 in H5Dcreate2(): unable to create dataset
    major: Dataset
    minor: Unable to initialize object
  #001: H5Dint.c line 490 in H5D__create_named(): unable to create and link to dataset
    major: Dataset
    minor: Unable to initialize object
  #002: H5L.c line 1695 in H5L_link_object(): unable to create new link to object
    major: Links
    minor: Unable to initialize object
  #003: H5L.c line 1939 in H5L_create_real(): can't insert link
    major: Symbol table
    minor: Unable to insert object
  #004: H5Gtraverse.c line 867 in H5G_traverse(): internal path traversal failed
    major: Symbol table
    minor: Object not found
  #005: H5Gtraverse.c line 639 in H5G_traverse_real(): traversal operator failed
    major: Symbol table
    minor: Callback failed
  #006: H5L.c line 1731 in H5L_link_cb(): name already exists
    major: Symbol table
    minor: Object already exists
error: Could not create dataset /created_dset1
error: called from
    h5test at line 76 column 1

shashwat1998 commented 3 years ago

Tried using the repository with your h5read.cc but got a bunch of errors like the one below- h5read.cc:89:13: error: ‘class Matrix’ has no member named ‘isvector’; did you mean ‘is_vector’? Similar errors for isinteger isreal iscomplex.

siko1056 commented 3 years ago

@shashwat1998 which Octave version do you use? Since Octave 4.4 there is no Matrix::is_vector() anymore

Since Octave 4.4 Matrix::is_vector() is deprecated and internally uses Matrix::isvector()

Same for Octave 6.1 https://octave.org/doxygen/6.1/d0/d26/classArray.html#a5e49a84c1bf87852ba6327703b67e5aa

siko1056 commented 3 years ago

Probably it is best to look at some more recent maintained fork https://github.com/tmullins/hdf5oct/network/members as @tmullins seems no longer to be working on this project anymore :wink:

tmullins / hdf5oct

GNU Octave 4.4 compatibility. #15