search

tmux-plugins / tmux-battery

Plug and play battery percentage and icon indicator for Tmux.
MIT License
503 stars 98 forks source link

Fix Battery Percentage When Grep Colors Is Set(Zsh) #101

Open KTSCode opened 3 years ago

KTSCode commented 3 years ago

When switching from bash to zsh on my Macbook the battery_percentage output went from the normal %100 to [1;35;40m[K100%[m[K after messing with it for a while I realized I had set GREP_OPTIONS='--color=always' in my .zshrc file and zsh was setting that env var in the script being used to output the battery_percentage. So the output was being wrapped in grep colorization.

This PR fixes the issue with grep attempting to colorize output for pmset by passing the option --color=never to the grep command in the battery percentage script.

*I realize that grep is used in many other places in this plugin but I don't have the resources to test all the other uses it's used at and am worried about breaking something by copying the change to all uses of grep without testing each one.

KTSCode commented 10 months ago

@martinbeentjes is there anything I need to do to get this PR merged?