search

tmux-plugins / tmux-battery

Plug and play battery percentage and icon indicator for Tmux.
MIT License
503 stars 98 forks source link

Range formatting and graph #16

Closed levens closed 8 years ago

levens commented 9 years ago

This is my own independent implementation similar to PR #13 & #14. It implements three level highlighting using two format strings #{battery_prefix} and #{battery_suffix} which surround the highlighted part of status-right or status-left. The exact strings to be substituted can be customised, for example to change the foreground/background colours (default green/yellow/red) and the threshold levels can be changed (default >=30% green, <30% yellow, <10% red).

A second new feature is a spark inspired graph showing the battery level as a single character (▁▂▃▅▇).

levens commented 8 years ago

Any chance of having this PR merged?

martinbeentjes commented 8 years ago

Currently, functionality on changing fore- and background based upon the percentage of the battery is already implemented. I will close this for now, thanks for your input anyway. Maybe I'll get back to this in the future.

levens commented 8 years ago

Hi @martinbeentjes,

It is a shame that @RyanFrantz is re-implementing what I did already ~2 years ago.

I have opened #37 to salvage the remaining features which have not been re-implemented.

Cheers,

martinbeentjes commented 8 years ago

I understand your concern, however I saw @RyanFrantz his PR other than yours. Therefore I merges his first, was not really sure what to think of your contribution (how I like it as a feature). I'll take a look at your new PR.