Auto-creating folders in logging path #2

tmux-plugins / tmux-logging

Easy logging and screen capturing for Tmux.

MIT License

1.03k stars 113 forks source link

Auto-creating folders in logging path #2 #21

Closed selfuryon closed 6 years ago

selfuryon commented 6 years ago

Hello! I created PR after some discussion on #20. The main changes are the way which variables work. Reduced the ambiguous path and filename with many get_tmux_option. So we don't need get_path like functions anymore

Based on this issue #19

selfuryon commented 6 years ago

Hello @bruno- ! Can you review my commit?

bruno- commented 6 years ago

Good stuff! Thank you for your work on this 👍 I think this is ready to be merged.

I left some comments, but none are deal-breaking. Let me know your thoughts!

selfuryon commented 6 years ago

I think I will refactor some part of code based on your comments and after make new PR for it :)

selfuryon commented 6 years ago

Hello, @bruno- ! I made the second commit with some optimization. Check it, please!

bruno- commented 6 years ago

@selfuryon thank you for the good work and patience!