search

tmux-plugins / tmux-logging

Easy logging and screen capturing for Tmux.
MIT License
1.05k stars 114 forks source link

Add "notes" to keybindings #60

Open Boruch-Baum opened 3 years ago

Boruch-Baum commented 3 years ago

By default, tmux binds PREFIX+~ to tmux command "list-keys -N", which display a relatively pretty listing of tmux keybindings, but only for those keybindings that were defined with a descriptive "note". This PR adds those notes for "tmux-logging" commands.

Boruch-Baum commented 3 years ago

It seems that none of the TPM plugins avail themselves of the -N option. Are you the maintainer of all of them? Would you like me to prepare parallel pull-requests for those other repositories? The down-side could be that you don't like the wording of my descriptions.

bruno- commented 3 years ago

This is a feature that was added to tmux 3.1. It was released in February 2020, which is relatively new. apt-get install tmux on ubuntu installs tmux 3.0a.

So, I think we're not yet ready for adding this flag to plugins. We should check again in 6 months or in a year.

Boruch-Baum commented 3 years ago

How about having the script check for a version, and operate accordingly? There shouldn't be any need to deprive many of us, and in 6/12 months we may forget.

tmux -V

=> tmux 3.1c

Let me know, and I can add the line(s)...

-- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0

Boruch-Baum commented 3 years ago

I have this now working locally with a version check.

-- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0