tmux-plugins / tmux-open

Tmux key bindings for quick opening of a highlighted file or url
MIT License
630 stars 63 forks source link

Tilde unexpanded in paths #18

Open Smattr opened 8 years ago

Smattr commented 8 years ago

Steps to reproduce:

$ ls ~/.tmux.conf
/home/smattr/.tmux.conf
$

Now go into copy mode, highlight ~/.tmux.conf and hit Ctrl+o.

Expected behaviour: My Tmux configuration is opened in Vim.

Actual behaviour: Vim opens a new file "~/.tmux.conf"


The cause is pretty clear (quotes around {} in the xargs expansion), but removing the quotes is clearly not correct. Digging a bit deeper, I learned that tilde expansion is much more complicated than I was aware (e.g. http://stackoverflow.com/a/29310477). Do you have any ideas how to solve this cleanly? Apologies if I have misdiagnosed the problem.

peri4n commented 6 years ago

+1

bruno- commented 6 years ago

Hi, if I remember correctly we added argument quoting to enable filenames with spaces. I'm not sure if manual tilde expansion is worth it.