Fix #53 - Githubissues

tmux-plugins / tmux-open

Tmux key bindings for quick opening of a highlighted file or url

MIT License

642 stars 62 forks source link

Fix #53 #54

Closed Freed-Wu closed 2 years ago

bruno- commented 2 years ago

The change looks good, but I can definitely see myself looking at this in 3 months and wondering "why do we have this set command here?".

Can you think of a way to briefly document this inline? Maybe a comment above each command? Or maybe:

extract the sed .... string in a function called maybe preserve_url_hash
document the function
Interpolate function output in all 3 places where needed echo "$(preserve_url_hash) ..."

Freed-Wu commented 2 years ago

Okay :smile: