search

tmux-plugins / tmux-resurrect

Persists tmux environment across system restarts.
MIT License
11.42k stars 424 forks source link

Maintain the value of automatic-rename #401

Closed Farzat07 closed 3 years ago

Farzat07 commented 3 years ago

An alternative implementation of #399.

Handles the unset case - if it was initially unset, it is kept that way.

Fixes #57. Fixes #343.

Farzat07 commented 3 years ago

Note that the -v option in "tmux show-window-options" removes the option name and only keeps its value (as desired).

Farzat07 commented 3 years ago

I wrote the second commit on a hurry so it is still buggy. I was busy the past few days with covid procedures as I will be travelling today. Hopefully I will fix it soon though. In the mean time you can check the implementation in general. I moved the window_name property from the pane data to window data, and while restoring I made the renaming happen before setting the automatic-rename option in the same function. Is that what you want?

bruno- commented 3 years ago

@Farzat07 I have reviewed the PR and left a couple small comments. I think the general direction is good. Let me know when you finalize the PR so I can review again. Thanks for working on this.

Farzat07 commented 3 years ago

Ok now it should be working fine.

Thanks for the reviews btw. Reviewing the code and testing for bugs is usually more difficult than writing the code if you ask me😅

bruno- commented 3 years ago

I think the PR looks good. I left two small comments.

I'll pull the changes to my computer and test it for a couple days to make sure everything is working good.

bruno- commented 3 years ago

Update: all comments are resolved and all is looking good. Thanks!

I'll test this for a couple days on local machine before merging.

bruno- commented 3 years ago

@Farzat07 thank you for working on this 🙏