Closed rjorgenson closed 2 years ago
Yeah, it is happening to me as well, it's a nightmare, because when I restore my session it creates new non-existing panes, and I tried removed manually and it still not working....
Ditto
Going back to v2.4.0 fixes the issue for me (git checkout tags/v2.4.0
in tmux-resurrect folder). You might have to recover a previous tmux_resurrect_xxxxxx.tmux
file and link it to last
.
@normen can you try this:
master
branchSo the tip is to update while tmux is still running, do I get that right?
That seemed to have worked but it seems a bit unlucky that 3.0 can't load saves from 2.4 properly?
So the tip is to update while tmux is still running, do I get that right?
Yep.
That seemed to have worked but it seems a bit unlucky that 3.0 can't load saves from 2.4 properly?
3.0 is a new major version https://semver.org
That seemed to have worked but it seems a bit unlucky that 3.0 can't load saves from 2.4 properly?
3.0 is a new major version https://semver.org
Usually incompatibilities of a major version are not a concern on the user side where appropriate importing mechanisms should be implemented. As per the doc you linked the incompatibilities are mainly about API changes, which are not a user concern. So thats only an excuse if you can explain why 3.0 can't load files written with 2.4 - which I suspect you can't 🙂
As you see, many people install this plugin via plugin managers like tpm and now - with about 6 years since the last official release this incompatibility bites people quite unexpectedly.
Reverting to v2.4.0 and restoring then upgrading and saving worked for me as well. Definitely frustrating that this workflow was broken for users but at least I was able to recover.
I guess we should write an upgrade doc and link to it from the readme. Any volunteers?
I suppose the hint would just be "3.0 can not load sessions stored in 2.4, make sure to update while your tmux session is still running and then immediately save a new session with 3.0".
Any resurrect upgrade should happen with tmux running. That should be the norm.
Then maybe add a special comment about upgrade to 3.0 in the README.
It might be worth including instructions to migrate a 2.4 save to a 3.0 save if someone has already upgraded like we had. Tmux is always running so it was definitely upgraded while running but the upgrade itself didn't trigger a new save and I hadn't made any changes to trigger a save in over 7 days in my session. The restore process was super simple though, this is exactly what I did to recover my save.
#: tmux kill-server
)#: cd ~/.tmux/resurrect && git checkout v2.4.0
)#: tmux
)#: cd ~/.tmux/resurrect && git checkout master
)<prefix>-C-s
)Resurrect should probably save a version number in its save files and check it when restoring. Even if it can't automatically migrate the old data, it should warn the user it can't (with a link to this issue perhaps or docs), then quit.
I saw something similar even when I saved with 3.0.0 and restored with 3.0. I'm not sure why so have gone back to 2.4.0 for now. If If I later have a chance to reproduce will create new bug on that, but wanted to share in the meantime in case others have seen similar symptom on pure 3.0.0.
Note, my issue may have been related to being upgraded to tmux 3.2 between save (with 3.0) and restore (also with 3.0). The problem looked similar to above though, windows were all named cat (or on some attempts bash). I also didn't have pane contents. I saw that pane_contents/restore was empty so I unzipped the pane_contents zip into that then tried again. That seemed to at least get window contents, but I still had to manually rename each window. I suggested in #410 that adding some logging would help with issues like these.
For some reason tmux-resurrect is no longer restoring any session parameters but does restore the correct number of windows/panes. Here is the contents of the tmux-resurrect file (sanitized)
After a restore from the above file this is the resulting resurrect file now
Did something change? It's been quite some time since I've had to use resurrect. This is happening across a few sessions on different hosts that I have. Is there a way to recover my old resurrect file other than manually?