tmux-plugins / tmux-sensible

basic tmux settings everyone can agree on
MIT License
1.76k stars 91 forks source link

sensible.tmux doesn't run #48

Open alpha0mega96 opened 5 years ago

alpha0mega96 commented 5 years ago

Error message reads: unknown-option: default-terminal

hholst80 commented 5 years ago

Which version of tmux are you using?

hholst80 commented 5 years ago

I think this is related to the changed handling of default-terminal

holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ git diff sensible.tmux
diff --git a/sensible.tmux b/sensible.tmux
index 5cf2af6..9704820 100755
--- a/sensible.tmux
+++ b/sensible.tmux
@@ -158,4 +158,4 @@ main() {
                        tmux display-message "Sourced .tmux.conf!"'
        fi
 }
-main
+#main
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ source sensible.tmux
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ main
unknown option: default-terminal
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ vi sensible.tmux
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ git diff sensible.tmux
diff --git a/sensible.tmux b/sensible.tmux
index 5cf2af6..c9db0f3 100755
--- a/sensible.tmux
+++ b/sensible.tmux
@@ -99,9 +99,9 @@ main() {
        fi

        # upgrade $TERM, tmux 1.9
-       if option_value_not_changed "default-terminal" "screen"; then
-               tmux set-option -g default-terminal "screen-256color"
-       fi
+       #if option_value_not_changed "default-terminal" "screen"; then
+       #       tmux set-option -g default-terminal "screen-256color"
+       #fi
        # upgrade $TERM, tmux 2.0+
        if server_option_value_not_changed "default-terminal" "screen"; then
                tmux set-option -s default-terminal "screen-256color"
@@ -158,4 +158,4 @@ main() {
                        tmux display-message "Sourced .tmux.conf!"'
        fi
 }
-main
+#main
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ source sensible.tmux
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$ main
holst@hholst-lt:~/.tmux/plugins/tmux-sensible$