search

tmux-plugins / tpm

Tmux Plugin Manager
MIT License
11.95k stars 420 forks source link

Add branch support for plugins #158

Closed rrothenberger closed 3 years ago

rrothenberger commented 5 years ago

Allows to specify branch for plugins by using set -g @plugin 'repo#branch'. If branch is not specified master will be used.

laggardkernel commented 5 years ago

A similar pull request GH-120 was opened in 2017. But there's no any response from the maintainer. What do the maintainers think about the feature for branch support? @bruno-

bruno- commented 5 years ago

Hey, I personally have never needed or used this feature in other plugin managers (eg for vim). The comments and upvotes from others are also not overwhelming.

rrothenberger commented 5 years ago

Hey, I actually needed that for some old plugins that have versions working with current tmux on some branches, so i made it. Thought that if I already made that then I should share that. But if you believe that it is not needed then feel free to close this.

bricewge commented 5 years ago

I would like to point out that having support of git branches in a packages manager is especially useful when waiting for a PR to be merged upstream. Since creating a branch by PR is the recommended Github workflow.

laggardkernel commented 5 years ago

@bricewge You get me. That's exactly how I got here. I opened a pull request for plugin tmux-logging and wanted to use the branch temporarily. Then I started searching the branch support feature and found this pull request.

mwcz commented 5 years ago

+1 for the same reasons mentioned above: testing PRs.

fcsonline commented 4 years ago

Any news about merging https://github.com/tmux-plugins/tpm/pull/120 to upstream?

ggadget6 commented 4 years ago

I'd also love this feature

bruno- commented 3 years ago

Ok guys, we'll add branch support.

Did anyone test PR #120 or this one and has any feedback? Things working ok?

bricewge commented 3 years ago

It's nice to hear that tpm will support branches!

I did not test #120, however I have been using this PR for more than a year without any issue.

rrothenberger commented 3 years ago

Ok guys, we'll add branch support.

Did anyone test PR #120 or this one and has any feedback? Things working ok?

@bruno- I did - created this one exactly because it was not working properly for me in some case - maybe for updates, not 100% sure right now.

fcsonline commented 3 years ago

Awesome! :tada: