search

tmux-plugins / tpm

Tmux Plugin Manager
MIT License
11.9k stars 417 forks source link

`install_plugins.sh` assumes default branch to be `master` #208

Closed stefanistrate closed 3 years ago

stefanistrate commented 3 years ago

Recently GitHub changed their default branch naming from master to main: https://github.com/github/renaming

The assumption in install_plugins.sh that the default branch is master does not hold any more.

bruno- commented 3 years ago

We have branch support for plugins that can be used for branches other than master, see https://github.com/tmux-plugins/tpm/pull/158

I'd be ok defaulting to main eventually, but I think we're not there yet. Since I think we're well covered for this problem I'll close the issue. If you think something needs to change (docs, defaults etc) reopen the issue, or even better - submit a PR.

laggardkernel commented 3 years ago

@bruno- No, we're talking the default branch to choose when it's not specified in the set -g @plugin settings. The default branch should be decided by git clone automatically but not hardcoded as master.

This is a bug introduced from GH-158. I've opened a PR to fix it, looking forward to your review.

bruno- commented 3 years ago

The above mentioned PR has been merged.