search

tmux-plugins / tpm

Tmux Plugin Manager
MIT License
12.07k stars 421 forks source link

GitHub rejects clones using user:pass:?@host construction #286

Open mcint opened 4 months ago

mcint commented 4 months ago

Notably it also seems that there's a short lag during which previous failures will prevent anonymous cloning over http, 1-5 minutes.

My process

I sources .tmux.conf, tried to run plugin-install. It reported nothing, and cloned nothing. (It should write error logs into its ~/.tmux / $XDG_CONFIG_HOME/tmux.

I looked at the tpm setup file, listed key binds to find the install-plugins command, and tmux show @plugin to confirm its input. Expected plugins names were present. I run the commands to install plugins and viewed the scripts, eventually calling them directly with bash tracing on bash -x .../install_plugins[.sh] both variants, and copied the git command constructed and used. 

ubuntu@host1:~/.tmux/plugins$ git clone --single-branch --recursive https://git::@github.com/tmux-plugins/tumx-resurrect
Cloning into 'tumx-resurrect'...
remote: Support for password authentication was removed on August 13, 2021.remote: Please see https://docs.github.com/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication. fatal: Authentication failed for 'https://github.com/tmux-plugins/tumx-resurrect/'
RossBarnie commented 4 months ago

As the error says, GitHub removed support for basic authentication so there's nothing TPM can do about that. If you want TPM to manage updates to a private repo, I believe you should be able to clone the private repo manually in the plugins directory and TPM will be able to pull (ie update) the repo based on the authentication method you chose when cloning.

nyrghzef commented 2 months ago

Why is this still open?

RossBarnie commented 2 months ago

@nyrghzef The last code update to this repo was almost 18 months ago and it's relatively unmaintained.