search

tmux-plugins / vim-tmux-focus-events

Make terminal vim and tmux work better together.
MIT License
351 stars 23 forks source link

Is this plugin still necessary for neovim #38

Closed lewis6991 closed 3 years ago

lewis6991 commented 3 years ago

On the README there is a link to this old vim patch about adding tmux focus reporting natively.

I took a look at the change to see if it could be applied to neovim and found neovim now uses a completely different implementation for its TUI.

Anyway I've tried uninstalling this plugin and as far as I can tell focus reporting works fine in neovim.

If someone else can confirm we should update the README and probably simplify the plugin by removing any neovim specific code (if there is any).

Thanks.

bruno- commented 3 years ago

As far as I remember there's no neovim specific code in this plugin. But yea, we should update the README if neovim doesn't need this plugin.

przepompownia commented 3 years ago

Indeed, on neovim inside tmux this plugin is unneeded. After removing it I noticed that on nvim-qt I have to run :checktime manually again or restore call tmux_focus_events#focus_gained() after FocusGained was triggered.