search

tmux-plugins / vim-tmux-focus-events

Make terminal vim and tmux work better together.
MIT License
351 stars 23 forks source link

Use the <nomodeline> argument in all 'doautocmd' invocations #8

Closed ralish closed 7 years ago

ralish commented 8 years ago

This stops any modelines from being processed after the autocommands. As we're only responding to events that shouldn't modify the buffer this is both recommended per the Vim documentation (autocmd.txt : Section 9) and avoids an edge case(s?) where re-applying modelines causes undesirable behaviour. It may also improve performance (though no idea how much!).

With respect to the edge case: if the settings in a modeline are being overridden by an autocommand, they won't work without the argument. This is because the modeline settings will always be applied after the autocommands have been run.

bruno- commented 7 years ago

Hey,

in order to merge this one I had to resolve the conflicts. I pulled it locally, resolved the changes and merged to master. Here's the commit: https://github.com/tmux-plugins/vim-tmux-focus-events/commit/3743ba76d74dd0d37f031a9ea5e7ea0fa822423f

bruno- commented 7 years ago

Closing this PR as the commit was manually merged to master.