Closed johanneskastl closed 8 months ago
@johanneskastl Thank you for this!
How is the package being checked out? How are it and its dependencies being installed?
e.g. If it's from git source, does poetry install --with=test,coverage,lint
work?
The package is built in a offline environment, aka all dependencies are being prepared beforehand. This means all of the other packages are being installed via openSUSE's RPM package manager. libtmux itself is being prepared from a PyPI tarball, which worked up until now. I can test and use the GitHub tarball, to see if this solves the issue.
@johanneskastl
MIGRATION
:I will make a fix for this and report when the release is pushed.
poetry build
cd dist/
tar xvf libtmux-0.27.0.tar.gz
ls libtmux-0.27.0/
CHANGES LICENSE PKG-INFO README.md conftest.py docs pyproject.toml src tests
__about__.py
:I'm confident this exists:
ls libtmux-0.27.0/src/libtmux
__about__.py __init__.py _compat.py _internal _vendor common.py exc.py formats.py neo.py pane.py py.typed pytest_plugin.py server.py session.py test.py window.py
currentmodule
directiveUnknown directive type: 'currentmodule' [myst.directive_unknown].
This should be fine to ignore.
I tried with 0.27.1 and one of the original errors (Unknown directive type: 'currentmodule'
) is gone.
I needed to work around the other one, as I need to rename the src
directory before the builds and rename it back, otherwise I run into some weird errors.
So I had to put __about__.py
back into src/libtmux/
and now the tests succeed. I could even re-enable the checks I had to disable a while ago:
IGNORED_TESTS="test_capture_pane"
IGNORED_TESTS="${IGNORED_TESTS} or test_capture_pane_start"
IGNORED_TESTS="${IGNORED_TESTS} or test_function_times_out"
IGNORED_TESTS="${IGNORED_TESTS} or test_function_times_out_no_rise"
IGNORED_TESTS="${IGNORED_TESTS} or test_function_times_out_no_raise_assert"
IGNORED_TESTS="${IGNORED_TESTS} or test_select_window"
IGNORED_TESTS="${IGNORED_TESTS} or test_new_window_with_environment[environment0]"
IGNORED_TESTS="${IGNORED_TESTS} or test_new_window_with_environment[environment1]"
IGNORED_TESTS="${IGNORED_TESTS} or test_split_window_with_environment[environment0]"
IGNORED_TESTS="${IGNORED_TESTS} or test_split_window_with_environment[environment1]"
%pytest -k "not (${IGNORED_TESTS})"
Hence: Closing this issue! Thanks for your help!
@johanneskastl Thank you for the detailed follow up!
Just packaged v0.24.1 for openSUSE. The "unknown pytest option" error from #496 is gone, but I get two other errors that cause the build to fail.
One regarding a
file not found
. And one regardingUnknown directive type: 'currentmodule' [myst.directive_unknown]
.The latter might be due to a dependency's version being too old, but the constraints in pyproject.toml are fulfilled AFAIK.
Any ideas?
Kind Regards, Johannes