search

tmux-python / tmuxp

🖥️ Session manager for tmux, build on libtmux.
https://tmuxp.git-pull.com/
MIT License
4.08k stars 232 forks source link

fix(load): passthru of tmux config_file #843

Closed zappolowski closed 2 years ago

zappolowski commented 2 years ago

f93179d9a6af8624ed98c44a5a8582b1c05c9f99 erroneously renamed the argument for libtmux.server.Server which is still called config_file.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 years ago

Codecov Report

Merging #843 (c88b134) into master (e9b0717) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c88b134 differs from pull request most recent head ab8e776. Consider uploading reports for the commit ab8e776 to get more accurate results

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          24       24           
  Lines        1613     1613           
  Branches      366      366           
=======================================
  Hits         1229     1229           
  Misses        275      275           
  Partials      109      109
Impacted Files Coverage Δ
src/tmuxp/cli/load.py 69.66% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tony commented 2 years ago

@zappolowski Well done, and nice job on the test too

Released v1.18.1 (GitHub, Tag, PyPI)

If you try it out, any better?

zappolowski commented 2 years ago

Works for me now ... sorry for the wrong typing in the test. :grimacing: