search

tmweigand / PMMoTo

Porous Media Morphological and Topological Analysis Toolkit
1 stars 0 forks source link

Set.globalID is not uniquely assigned #13

Closed rileyvickers closed 1 year ago

rileyvickers commented 1 year ago

Checking with the gatherSetData we wrote yesterday, there are repeats of globalID, see attached csv of all setData

row 1 is arbitrary information col 1 is array index of set information in setData col 2 is globalID of set in setData, note the early repeats

Based on number of repeats, might have something to do with boundary behavior, i.e. multiple processors are adding info for shared sets?

Investigating now, can talk later today, may make some changes to sets.pyx setData.csv

tmweigand commented 1 year ago

That is correct. The localID is unique but the globalID is not. The globalID connect sets across multiple subDomains. I think what you want to do is merge the golbalConnectedSets for the duplicated globalIDs or maybe each one has all the required information and then you just delete duplicates.

tmweigand commented 1 year ago

Minor correction, localID is unique only on a processor level.

rileyvickers commented 1 year ago

Ohh I see, looking at globalconnected this is tracking with the latter of the statements from the previous comment.

Entries of globalConnectedSets are identical, just occasionally reordered. Will confirm this is the case and then pick the correct option based on whether a merge is needed or a deletion of the repeats is sufficient