search

tnc-ba / strongTNC

BYOD TNC Database Management Tool
GNU Affero General Public License v3.0
0 stars 0 forks source link

Return Codes for SWID Generator #104

Closed dbrgn closed 10 years ago

dbrgn commented 10 years ago

0 - OK 1 - No Results 2 - Bad arguments

dbrgn commented 10 years ago

Please rebase PR against current master.

dbrgn commented 10 years ago

Oh, awesome, a return code of 2 is the default for all argparse errors: https://docs.python.org/2/library/argparse.html#argparse.ArgumentParser.error

There's one thing left: I'd suggest using a return code of 3 for a failed autodetection (line 51 in swid_generator/main.py). What do you think?

cfaessler commented 10 years ago

Ok, is implemented in https://github.com/tnc-ba/swidGenerator/commit/604d197e20d69d62afaf8765706eebff8d6ee0f2

cfaessler commented 10 years ago

@dbrgn ready for review: https://github.com/tnc-ba/swidGenerator/pull/18