search

tnc-ba / strongTNC

BYOD TNC Database Management Tool
GNU Affero General Public License v3.0
0 stars 0 forks source link

Ajax endpoints not authenticated #193

Closed cfaessler closed 10 years ago

d22 commented 10 years ago

@dbrgn, please review. I added a test user and a login to the ajax tests. Should we add auth tests as well?

dbrgn commented 10 years ago

Looks good. Yes, it would be good if we test the authentication.

It'd be enough to add a test that verifies the authentication. It would be enough to assert that the return code without auth is 401. The authenticated functionality is already covered with other tests.

dbrgn commented 10 years ago

@cfaessler can you take a quick look at this PR?

cfaessler commented 10 years ago

Looks good to me