tnc-ba / strongTNC

BYOD TNC Database Management Tool
GNU Affero General Public License v3.0
0 stars 0 forks source link

Common ajax loading indicator for 'every' ajax request #202

Closed d22 closed 10 years ago

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.09%) when pulling 19816c30075086dafe038ca01a843ae805247be2 on issue202-loading-indicator into c9c4687a6cbce71737190dad433460b7a2e8cc40 on master.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.09%) when pulling 19816c30075086dafe038ca01a843ae805247be2 on issue202-loading-indicator into c9c4687a6cbce71737190dad433460b7a2e8cc40 on master.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.09%) when pulling ce0b1e95603c5804cfa7876575852d5ac1694c79 on issue202-loading-indicator into c9c4687a6cbce71737190dad433460b7a2e8cc40 on master.

cfaessler commented 10 years ago

@d22 What do you think about this?

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 134a42643346d2134cf9ab028dc70b8b9d497e5b on issue202-loading-indicator into c9c4687a6cbce71737190dad433460b7a2e8cc40 on master.

dbrgn commented 10 years ago

I am not shure sure

:laughing: :+1:

d22 commented 10 years ago

Currently there is an error on the SWID inventory view, because ajaxSpinner is still referenced in swid-inventory.js, but this shouldn't be a problem after rebasing, #282 fixes this.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 2790f56ef2de5b8f1bad3fde6e49470281fce1b2 on issue202-loading-indicator into 6a43832a6f25a449d25f89e947ba9dbd2588e0a1 on master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling bfa0ae8c74a31100e0d1fd10828b3cfbccc3c0ed on issue202-loading-indicator into 6a43832a6f25a449d25f89e947ba9dbd2588e0a1 on master.

d22 commented 10 years ago

Do something like this in paging.js:114:

ajaxWrapper.call(Dajaxice.apps.front.paging, callback, paramObject, {'error_callback': function() {
    alert('Error: Failed to fetch "' + paramObject.config_name + '" paging.');
    this.loading = false;
}.bind(this)});
cfaessler commented 10 years ago

@d22 I applied the changes.

d22 commented 10 years ago

GOMERGE! image