Fix hash navigation browser history

tnc-ba / strongTNC

BYOD TNC Database Management Tool

GNU Affero General Public License v3.0

0 stars 0 forks source link

Fix hash navigation browser history #238

Closed dbrgn closed 10 years ago

dbrgn commented 10 years ago

See https://github.com/tnc-ba/strongTNC/commit/009d6eb1b3375d615a786e44fbe5f3cdee849162#commitcomment-6447782.

This doesn't work very well. Whenever the hash is changed it causes a new entry in the browser's history. Especially with the changes in c6cb544 up to two two additional entries are created when navigating to a new page. Using window.location.replace might be an option, or history.replaceState(), if supported by the browser.

d22 commented 10 years ago

Tnx for testing and reviewing @dbrgn!

coveralls commented 10 years ago

Coverage remained the same when pulling 502fd5f7d91df240708fe14bc2ef6fb1786bd807 on issue238-improve-browser-history-behaviour-with-ajax-paging into c65f2a97a5bed282f0df60a3e4d903d75365149e on master.

coveralls commented 10 years ago

Coverage remained the same when pulling d6a6d7cc4d6cd9d5775c7448e9515a7cf24e6ee5 on issue238-improve-browser-history-behaviour-with-ajax-paging into e1be9026b4da192955f11152020cdc95684ea6ed on master.

dbrgn commented 10 years ago

zlad