Fix get_sessions_in_range

dbrgn commented 10 years ago

I guess this wasn't really different before, but selecting sessions from a single day, by selecting the same date in the from and to fields, is not possible this way. Actually if to is the current date, sessions from today won't be shown. A simple fix would be to just add one day to the value in to here, but since the submitted timestamp could include a time that might not yield the correct result. Another option is to "fix" the timestamp on the client before submitting, i.e. make the time part of the to date always 23:59:59 instead of 00:00:00, which I suppose is the default.

See https://github.com/tnc-ba/strongTNC/commit/0fd15b65a59dfdab72c793d0e85cb224d43a16d7#commitcomment-6448056

dbrgn commented 10 years ago

The test is currently failing. In order to fix this:

We need to treat the timestamps selected in the log/inventory view as localtime
The first "point of contact" with Python code needs to conver the "local timestamps" to "utc timestamps" before passing them on.
This needs to be documented in those places.

dbrgn commented 10 years ago

Blocked by #282.

dbrgn commented 10 years ago

Please review this madness, @d22.

coveralls commented 10 years ago

Coverage decreased (-0.05%) when pulling 907251f41a1007ed015a98d9e0c2ec90202a44b5 on issue243 into 48e05670b1a125911f2c65011fe6639b34bf50d1 on master.

coveralls commented 10 years ago

Coverage decreased (-0.05%) when pulling 907251f41a1007ed015a98d9e0c2ec90202a44b5 on issue243 into 48e05670b1a125911f2c65011fe6639b34bf50d1 on master.

d22 commented 10 years ago

MERGE, MASTER OF TIME! :clock1030:

tnc-ba / strongTNC

Fix get_sessions_in_range #243