Consistent column order

tnc-ba / strongTNC

BYOD TNC Database Management Tool

GNU Affero General Public License v3.0

0 stars 0 forks source link

Consistent column order #246

Closed cfaessler closed 10 years ago

cfaessler commented 10 years ago

Package name column shell be the first column. In general check for consistency in all views

cfaessler commented 10 years ago

@d22 can you please review, thx

d22 commented 10 years ago

~~Generally good and good to merge, but should we add the version column to the regid-tag-table as well (super consistent order :wink: )?~~ Edit: Please update according to today's meeting:

[x] Add version column in regid table
[x] unique_id should be first column in all tables
[x] Add packagename to swid-log

cfaessler commented 10 years ago

Other points will be done with paging of the swid log view

cfaessler commented 10 years ago

@d22 Good to merge?

coveralls commented 10 years ago

Coverage remained the same when pulling d564175182afb872aff7e911636033052a0f464e on issue246-column-order into c2d79bf22635257c91afba0b8ac41251c57ee255 on master.

cfaessler commented 10 years ago

@d22 can you please review the changes, thx.

coveralls commented 10 years ago

Coverage decreased (-1.21%) when pulling 6e0903a99ff6709c3ab973bf98f718de5bc962e0 on issue246-column-order into 6a43832a6f25a449d25f89e947ba9dbd2588e0a1 on master.

d22 commented 10 years ago

See comment regarding comment... Regarding the test, ztoopid @d22 (:cold_sweat:) is to blame. master is failing atm, can you please fix the PEP8 issue? Tnx :heart_decoration: Otherwise good to merge!