Swid tag replacement bug

[cfaessler]

If an already existent swid tag is replaced, entity relationships are not updated correctly. Don't know if they are updated at all, but adding an additional entity (e.g with role publisher) does not work. The additional entity is not shown in the tag view.

[dbrgn]

241 should get merged before starting this.

[cfaessler]

As discussed the behaviour should be as follows:

• SWID tags should be completely overwritten by import via manage.py importswid command
• Existing SWID tags should be kept (and not changed/extended) by posting via API

[coveralls]

Coverage increased (+0.03%) when pulling 782158c7fbfb11e7152154ddae4b26c8fc14bb6c on issue259-tag-replacement into 9ebdde6aa291683e2bc46f72244cc4f37a607396 on master.

[coveralls]

Coverage increased (+0.03%) when pulling 8be60b79abb77a036054d8fa99164c0ab14e582f on issue259-tag-replacement into 9ebdde6aa291683e2bc46f72244cc4f37a607396 on master.

[cfaessler]

Changes:

• API calls do not allow updates on existing tags
• Importswid command allows updates on existing tags
• Added and restructured tests

[cfaessler]

@dbrgn can you please review, thx

[coveralls]

Coverage increased (+0.03%) when pulling 4a0f5174cb1ab43da40277f8c1157b163a5b6a0f on issue259-tag-replacement into 9ebdde6aa291683e2bc46f72244cc4f37a607396 on master.

[dbrgn]

Review done :horse_racing:

[coveralls]

Coverage decreased (-0.07%) when pulling 88ad6e3625a9a0df60fda3ec8c75f9e272a97e3b on issue259-tag-replacement into b30e710bad62597a93b10adff881e63200a4e063 on master.

[coveralls]

Coverage decreased (-0.04%) when pulling 92d11e5b998548f6f85f0155bc93cdbc0393e1ea on issue259-tag-replacement into b30e710bad62597a93b10adff881e63200a4e063 on master.

[cfaessler]

SWID import now behaves as follows:

• Manage.py importswid: Trying to create an already existing tag will replace all tag attributes.
• API swid creation: The tag will not be changed and will be reported as already existing.

In any case, if the entity name changes, it will be updated. The raw SWID XML (for previously existing tags) stays unchanged and still contains the old entity name.

@strongX509 is that the desired behaviour?

[dbrgn]

Did some small formatting changes. Good to merge from my side.

[coveralls]

Coverage decreased (-0.3%) when pulling 467167ab4288dfd10b89557bdda6af0b622c9b90 on issue259-tag-replacement into b30e710bad62597a93b10adff881e63200a4e063 on master.

[cfaessler]

fixed by https://github.com/tnc-ba/strongTNC/commit/45a394bd3705c5a5833b7afec1f5d43d8a517c75

[coveralls]

Coverage increased (+0.04%) when pulling 970d3c0d48f639a8ec5da9a9a26ebda7677183e8 on issue259-tag-replacement into de39e8dd8877dc28f98301117b273a9e0aaa4aae on master.