search

tnc-ba / strongTNC

BYOD TNC Database Management Tool
GNU Affero General Public License v3.0
0 stars 0 forks source link

Wrong session info in 'Device report' #279

Closed d22 closed 10 years ago

d22 commented 10 years ago

Bugreport by @strongX509:

Device Infos ID cd7053aa0e7c902c5260b274e76a14169d57f623 Description AIK Test Last user steffen Last session May 29 11:55:36 2014 Last assessment Block Total Sessions 3

Die ID, Description und Total Sessions Einträge beziehen sich auf das spezifische Device und sind richtig.

Last user, Last session und Last assessment beziehen sich auf die letzte Session überhaupt und nicht auf die letzte Session für das spezifische Device. D.h. der Primary Key des Device muss in die sessions query eingehen.

Können Sie dies noch fixen?

d22 commented 10 years ago

@dbrgn, please check and review. Tnx.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.03%) when pulling 6bd2c2817c78557d383cff5c3130e42a02db0567 on issue279-wrong-session-in-device-report into 032d8e3354d12a4a496b955329ecfcc1f03f4f97 on master.

dbrgn commented 10 years ago

Review done.

d22 commented 10 years ago

Made changes according to review. @dbrgn, please check again.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling b283655c934c739df7778b2fbf350f921a552612 on issue279-wrong-session-in-device-report into c2d79bf22635257c91afba0b8ac41251c57ee255 on master.

dbrgn commented 10 years ago

Looks good!