search

tnc-ba / strongTNC

BYOD TNC Database Management Tool
GNU Affero General Public License v3.0
0 stars 0 forks source link

Name attibute in entity tag is wrong (swid-generator) #39

Closed d22 closed 10 years ago

d22 commented 10 years ago

The name attribute in the entity generator has currently the wrong value (packagename).

From the ISO standard: 

The name of the organizatio claiming a particular role in the SWID tag.

The commandline arguments and the value itself should be updated.

cfaessler commented 10 years ago

is there a need to update this file https://github.com/tnc-ba/swidGenerator/blob/generator-base/Documentation/SWID-Template.xml accordingly?

we should also check the regex used for validation, i'm not completely shure it matches the standard. It also allows , for regid \w only matches

d22 commented 10 years ago

I updated the SWID-Tag template to match the implementation/standard.

Also, I modified the regexes for the regid and the entity name, its closer to the standard now, but it does not cover every requirement. We should have a look at it togheter, maybe we're close enough.

@cfaessler, please review my changes.

cfaessler commented 10 years ago

looks good to me!

d22 commented 10 years ago

Oke, tnx. I will close this issue.