search

tnc-br / ddf-isoscapes

4 stars 0 forks source link

Xgbminimal notebook (minimal Oxygen generation with refactored common fns) #143

Closed benwulfe closed 1 year ago

benwulfe commented 1 year ago

This is a new notebook that represents a refactored/minimal XGB Oxygen generation model.

It has a supporting PR here in ddfcommon that must come first: https://github.com/tnc-br/ddf_common/pull/3

After submitting this PR, we can clean up the other notebooks for XGB and the code in this repo such that only this minimal notebook will exist.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rothn commented 1 year ago

I would feel better if load_xgb and save_xgb used os.path.join instead of trying to concatenate themselves

rothn commented 1 year ago

I see this still uses dataset.yearly_255_tress_partitioned. Can we clean this up at some point? Maybe file a bug?

benwulfe commented 1 year ago

load_xgb and save_xgb used os.path.join https://github.com/tnc-br/ddf-isoscapes/issues/147

test_train_or_load_xgboost added

yearly_255_tress_partitioned renamed to partitioned_reference_data