search

tnc-br / ddf-isoscapes

3 stars 0 forks source link

Start printing validation RMSE #161

Closed VimWizardVersace closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rothn commented 1 year ago

There already exists a notebook that calculates RMSE as part of the validation pipeline. We shouldn't couple it to the notebook we use that generates the isoscape of the model.

https://github.com/tnc-br/ddf-isoscapes/blob/main/validation_pipeline.ipynb

Agreed, but we should have a fast and easy way to include this calculation in the notebook people use to iterate on the model. Is this callable as a library?

rothn commented 1 year ago

What I have been doing when there's an existing implementation and want to use it in another notebook is to move/implement it into ddf-common for future instances.

I've created PR that makes this available. Please use this using ddfimport. tnc-br/ddf_common#21

Approved, feel free to merge, @erickzul