search

tnc-br / ddf-isoscapes

3 stars 0 forks source link

User-friendly(er) of variational inference script #174

Closed erickzul closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

VimWizardVersace commented 1 year ago

You created a new file at the root directory instead of replacing dnn/variational_inference.ipynb

Is that on purpose? Why keep the other?

VimWizardVersace commented 1 year ago

# X.insert(len(X.columns)-3, name, X.pop(name))

You can delete this. This is only needed in the boosted version of the model.

VimWizardVersace commented 1 year ago

LGTM, just clear the outputs before submitting