search

tnc-br / ddf-isoscapes

3 stars 0 forks source link

Update variational inference isoscape generation code to use new model.py constructor #176

Closed VimWizardVersace closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

VimWizardVersace commented 1 year ago

please combine code blocks and reduce click count. If code blocks are too big, can refactor out to ddfcommon, but to start, reducing the click count is better especially for a non-expert user of python who may easily miss a code block.

I found that they don't really look at the number of different sections. They typically would just run runtime -> run all

Otherwise they'd have to manually click to run ~30 sections in the validation pipeline