tnc-br / ddf-isoscapes

3 stars 0 forks source link

Update variational inference notebook with sensible defaults to work of-the-box #192

Closed rothn closed 11 months ago

rothn commented 11 months ago

Currently, the training notebook does not run out-of-the-box after running the data ingestion notebook. A minimal set of modifications did not produce a good model, so I also performed some minor tuning to help ensure a good out-of-box experience for anyone who tries this.

Changelist:

Reference Performance (splits from https://github.com/tnc-br/ddf_common/pull/46): Val loss: 1.397790789604187 Train loss: 0.9393936395645142 Test loss: 0.9468271732330322 dO18 RMSE: 0.9135236042418461

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

VimWizardVersace commented 11 months ago

I noticed lower patience undertrained when doing distribution sampling. Looking at the loss graphs in this training run, I feel like it could keep improving.

I agree 2000 is too much, but 30 is too little. Change it to 100?

rothn commented 11 months ago

I noticed lower patience undertrained when doing distribution sampling. Looking at the loss graphs in this training run, I feel like it could keep improving.

I agree 2000 is too much, but 30 is too little. Change it to 100?

Sounds good. Agreed that it's kind of low, and 100 might be better especially based on the graph like you say

VimWizardVersace commented 11 months ago

Approved conditional on the patience level change