tnc-ca-geo / animl-frontend

A frontend web app for viewing & labeling camera trap data by The Nature Conservancy.
https://animl.camera
Other
16 stars 0 forks source link

Address security alerts #73

Closed nathanielrindlaub closed 1 year ago

nathanielrindlaub commented 2 years ago

We'll have to wait on upgrading to CRA v5: https://github.com/tnc-ca-geo/kelpwatch/issues/212

nathanielrindlaub commented 2 years ago

Can't bump react-router to v6, because connected-react-router doesn't support it yet. One option is to ditch connected-react-router in favor of redux-first-history, like we did in Kelpwatch.

nathanielrindlaub commented 2 years ago

Ran into the following @aws-amplify/ui-react issue when trying to upgrade. Sounds like for now the only workaround is to upgrade to CRA v5...

nathanielrindlaub commented 2 years ago

And evidently react-dates doesn't support React v17, so reverting back to v16.x. Giving up for now.

nathanielrindlaub commented 1 year ago

If the Create React App issues persist, it might be worth looking into transitioning to Vite - https://blog.logrocket.com/vite-3-vs-create-react-app-comparison-migration-guide/

nathanielrindlaub commented 1 year ago

I think it is time to switch to Vite and it is pretty high priority as we can no longer use Radix Primitives w/o using Craco with CRA.

nathanielrindlaub commented 1 year ago

Transitioning to Vite fixed the vast majority of security alerts, so closing this out for now, but we should still: