search

tnelson / Forge

Forge: A Tool and Language for Teaching Formal Methods
https://forge-fm.org/
MIT License
67 stars 8 forks source link

Unset _JAVA__OPTIONS in `java>=1.9?' #193

Closed TsarFox closed 1 year ago

TsarFox commented 1 year ago

Closes #192.

bennn commented 1 year ago

Ok, but why not change the regexp to lose the ^ ?

TsarFox commented 1 year ago

Ok, but why not change the regexp to lose the ^ ?

I just went with what felt less error-prone in the moment. If the one-character fix is preferable I'm happy to update this MR; I don't have any compelling reasons to see it done this way

bennn commented 1 year ago

I'm worried the env-vars copy could get expensive. Would prefer the regex black magic.

@tnelson any opinions?

bennn commented 1 year ago

thank you @TsarFox