tnevolin / thinker-doer

Modifications to a SMACX Thinker mod to highlight more game features
GNU General Public License v2.0
27 stars 3 forks source link

Framing actions against Pactmates carry no consequences #51

Closed nevill-spb closed 3 years ago

nevill-spb commented 3 years ago

Issue:

Be pacted with a computer player. Commence Probe Team action against the same computer player, and frame someone else. Get caught. The pactmate will say they would renounce the pact immediately, but won't actually do anything.

(also, in MP a window would pop up asking the current player - the one commencing the probe operation - what to do on behalf of the framed player. While making a decision for another player is weird design, it might actually be workin as intended, since probing actions require an immediate reaction. But it probably shouldn't be prompting about it when your two factions are already at Vendetta. Just mentioning this in case you will be looking at the code)

During the act (probe team is caught) FrameJob_1 Stated consequences: FrameJob_4 Actual consequences (nothing): FrameJob_2 FrameJob_3

This allows you to attempt actions against a pact mate with impunity at somewhat reduced chance of success.

Doing the same action without a framejob would cause the relationship to degrade correctly, with a corresponsing decrease in Integrity.

tnevolin commented 3 years ago

OMG. Where do you dig them out from? I was never even aware of this one. 😁 Will look at it.

tnevolin commented 3 years ago

I have tested this and it worked as designed. Both factions (penetrated and framed) declared vendetta on me. Maybe you indeed caught a bug but there should be other conditions to it. Does it happen only in MP?

tnevolin commented 3 years ago

Closing as unable to reproduce. See my last comment above.