search

tnevolin / thinker-doer

Modifications to a SMACX Thinker mod to highlight more game features
GNU General Public License v2.0
27 stars 3 forks source link

Please consider not storing releases in git repo #74

Closed Voker57 closed 3 years ago

Voker57 commented 3 years ago

The whole point of git is that history is always available. If you make tags, people can always obtain past release version (git archive). Storing zips in git is useless and just wastes space on clone.

tnevolin commented 3 years ago

Thank you for pointing this out. Some people don't know git but still want to get their version zip file. What is the option for them?

Voker57 commented 3 years ago

Thank you for pointing this out. Some people don't know git but still want to get their version zip file. What is the option for them?

Git automatically packages tags in zip files, just push a tag and it will be available to download from releases.

tnevolin commented 3 years ago

WHAT does it automatically package in zip files? I don't think it packages what and how I want it to. This is a custom zip with some structure and selected files in it.

Voker57 commented 3 years ago

WHAT does it automatically package in zip files? I don't think it packages what and how I want it to. This is a custom zip with some structure and selected files in it.

Ah, you're right, sorry. You'd have to set up actions to build release files https://docs.github.com/en/actions/learn-github-actions, or upload them manually.

tnevolin commented 3 years ago

Yes. I am looking at this and should probably try to upload them manually to exclude from code base. Thank you for pointer! I will see how it works in next release.